| From: | Melanie Plageman <melanieplageman(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com>, masao(dot)fujii(at)oss(dot)nttdata(dot)com, gkokolatos(at)protonmail(dot)com, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: shared-memory based stats collector - v66 |
| Date: | 2022-03-21 21:41:48 |
| Message-ID: | CAAKRu_Zu=8WD3sHyiU-b_DPmP5ic_9CHw9S1vAex44VcNUUNQA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Mar 20, 2022 at 4:56 PM Melanie Plageman
<melanieplageman(at)gmail(dot)com> wrote:
>
> Addressed all of these points in
> v2-0001-add-replica-cleanup-tests.patch
>
> also added a new test file in
> v2-0002-Add-TAP-test-for-discarding-stats-after-crash.patch
> testing correct behavior after a crash and when stats file is invalid
>
Attached is the last of the tests confirming clean up for stats in the
shared stats hashtable (these are for the subscription stats).
I thought that maybe these tests could now use
pg_stat_force_next_flush() instead of poll_query_until() but I wasn't
sure how to ensure that the error has happened and the pending entry has
been added before setting force_next_flush.
I also added in tests that resetting subscription stats works as
expected.
- Melanie
| Attachment | Content-Type | Size |
|---|---|---|
| add_subscriber_stats_tests.patch | text/x-patch | 11.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2022-03-21 21:54:38 | Re: logical decoding and replication of sequences |
| Previous Message | Thomas Munro | 2022-03-21 21:38:32 | Re: [PATCH] add relation and block-level filtering to pg_waldump |