Re: Log connection establishment timings

From: Melanie Plageman <melanieplageman(at)gmail(dot)com>
To: Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Guillaume Lelarge <guillaume(at)lelarge(dot)info>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Daniel Gustafsson <daniel(at)yesql(dot)se>, andrey(dot)chudnovskiy(at)microsoft(dot)com, Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>, Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>
Subject: Re: Log connection establishment timings
Date: 2025-03-04 17:07:31
Message-ID: CAAKRu_Zawq3hVvgoZdeuvpx6-54RvYqcvCYfFajGXw42OiW4Eg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Mar 4, 2025 at 4:40 AM Bertrand Drouvot
<bertranddrouvot(dot)pg(at)gmail(dot)com> wrote:
>
> On Mon, Mar 03, 2025 at 06:24:59PM -0500, Melanie Plageman wrote:
> >
> > And I think it would be even simpler to do your idea of groups and to
> > have aliases for different combinations of options. And it would let
> > us keep 'on' and 'off' as backwards compatibility aliases.
>
> hm, I think that's a very interesting idea. Being able to preserve backward
> compatibility is certainly a big bonus (as long as the values keep doing the
> exact same thing).
>
> > Maybe if I tried implementing it, it wouldn't work at all. But, as it
> > stands, I'm feeling nervous about making two of the most common GUCs
> > in the world (log_connections and log_disconnections) less structured.

I tried to mock up a prototype this morning of PGC_ENUM_LIST (or
PGC_SET, not sure what to call it) and actually parsing the enum list
input was easy to do, but there are a bunch of other things to figure
out that will take time.

Anyway, I'll start polishing the enum "on", "off", "timings" version
of my patch.

- Melanie

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Jacob Champion 2025-03-04 17:08:00 Re: [PoC] Federated Authn/z with OAUTHBEARER
Previous Message Jelte Fennema-Nio 2025-03-04 17:02:25 Re: Next commitfest app release is planned for March 18th