| From: | Melanie Plageman <melanieplageman(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Jeff Davis <pgsql(at)j-davis(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Tomas Vondra <tv(at)fuzzy(dot)cz>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: hashagg slowdown due to spill changes |
| Date: | 2020-06-23 16:23:57 |
| Message-ID: | CAAKRu_ZVD47byoEdR7C=nv2mf3SYB+qqQVmHJi4ON0b+PhvxqA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jun 22, 2020 at 9:02 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
>
> > /*
> > - * find_unaggregated_cols
> > - * Construct a bitmapset of the column numbers of un-aggregated Vars
> > - * appearing in our targetlist and qual (HAVING clause)
> > + * Walk tlist and qual to find referenced colnos, dividing them into
> > + * aggregated and unaggregated sets.
> > */
> > -static Bitmapset *
> > -find_unaggregated_cols(AggState *aggstate)
> > +static void
> > +find_cols(AggState *aggstate, Bitmapset **aggregated, Bitmapset
> **unaggregated)
> > {
>
> It's not this patch's fault, but none, really none, of this stuff should
> be in the executor.
>
>
Were you thinking it could be done in grouping_planner() and then the
bitmaps could be saved in the PlannedStmt?
Or would you have to wait until query_planner()? Or are you imagining
somewhere else entirely?
--
Melanie Plageman
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2020-06-23 17:06:13 | Re: hashagg slowdown due to spill changes |
| Previous Message | Alvaro Herrera | 2020-06-23 16:22:12 | Re: pg_resetwal --next-transaction-id may cause database failed to restart. |