Re: Count and log pages set all-frozen by vacuum

From: Melanie Plageman <melanieplageman(at)gmail(dot)com>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Nitin Jadhav <nitinjadhavpostgres(at)gmail(dot)com>, Alastair Turner <minion(at)decodable(dot)me>, Peter Geoghegan <pg(at)bowt(dot)ie>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>
Subject: Re: Count and log pages set all-frozen by vacuum
Date: 2024-12-17 19:34:00
Message-ID: CAAKRu_YzUXSd3oLWTSsteLhKaOzFUhcOz7acof26Q3-pdF1V4w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Dec 16, 2024 at 7:14 PM Melanie Plageman
<melanieplageman(at)gmail(dot)com> wrote:
>
> On Wed, Dec 11, 2024 at 2:18 PM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> >
> > I agree that it will be unimportant from Melanie's work in this area.
> > Also, I agree that if semi-aggressive vacuum has its own new logging
> > message about what it's done, this new message doesn't necessarily
> > need to be detailed. But looking at the proposed patches, there seems
> > to be no such new logging message so far. Showing three categories
> > makes sense to me independent of semi-aggressive vacuum work. If we
> > figure out it's better to merge some parts of this new message to
> > semi-aggressive vacuum's logs, we can adjust them later.
>
> Yes, actually after some review feedback on the eager vacuum patch set
> from Andres, I switched my approach and these counters are no longer a
> dependency. (I still require the second patch in this set).
>
> However, through this discussion, I've come to think that the VM
> logging is useful. As such I plan to commit attached v5 (which
> addresses review feedback and incorporates Tomas' wording suggestion).

I've committed this and marked the commitfest entry as committed as well.

Thanks everyone for your review and input.

- Melanie

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2024-12-17 19:34:35 Re: Maybe we should reduce SKIP_PAGES_THRESHOLD a bit?
Previous Message Andres Freund 2024-12-17 19:25:01 Re: Adding NetBSD and OpenBSD to Postgres CI