| From: | Melanie Plageman <melanieplageman(at)gmail(dot)com> |
|---|---|
| To: | Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> |
| Cc: | Kirill Reshke <reshkekirill(at)gmail(dot)com>, Matheus Alcantara <mths(dot)dev(at)pm(dot)me>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Using read stream in autoprewarm |
| Date: | 2025-03-31 19:45:09 |
| Message-ID: | CAAKRu_YqGhQLei3Oom7N0VzG7zVJ9v-WjH-cv0F8O+_zHuBOtA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Mar 31, 2025 at 3:27 PM Melanie Plageman
<melanieplageman(at)gmail(dot)com> wrote:
>
> I think there might be another problem with the code. We only set
> cur_database in the loop in autoprewarm_databas_main() when it is 0
>
> if (cur_database != blk->database)
> {
> if (cur_database == 0)
> cur_database = blk->database;
>
> I know that the read stream will return InvalidBlockNumber when we
> move onto the next database, but I don't see how we will end up
> actually stopping prewarming in autoprewarm_database_main() when we
> move on to the next database.
Whoops, this isn't right. It does work. I'm going to draft a version
suggesting slightly different variable naming and a couple comments to
make this more clear.
- Melanie
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2025-03-31 20:11:13 | Re: pgsql: Add memory/disk usage for Window aggregate nodes in EXPLAIN. |
| Previous Message | Masahiko Sawada | 2025-03-31 19:35:23 | Re: Make COPY format extendable: Extract COPY TO format implementations |