| From: | Melanie Plageman <melanieplageman(at)gmail(dot)com> |
|---|---|
| To: | Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> |
| Cc: | Matheus Alcantara <matheusssilv97(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, jian he <jian(dot)universality(at)gmail(dot)com>, Kirill Reshke <reshkekirill(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: read stream on amcheck |
| Date: | 2025-03-27 18:35:44 |
| Message-ID: | CAAKRu_YjeGtOK2o-Jra4wWjh+3OtuBT+LQprb6fry0VhUJbzGA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Mar 27, 2025 at 4:45 AM Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> wrote:
>
> I liked the first approach more. We can solve the first approach's
> problems by introducing a void pointer to pass to
> read_stream_begin_relation(). We can set it to &rsdata.range for the
> SKIP_PAGES_NONE case and &rsdata for the rest.
Cool. I've gone with this approach but have renamed all the functions
and structs to try and be more consistent and clear.
Committed in 043799fa08c2c and I marked the commitfest entry as such.
- Melanie
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Matheus Alcantara | 2025-03-27 18:45:46 | Re: read stream on amcheck |
| Previous Message | Robert Haas | 2025-03-27 18:32:27 | Re: Remove restrictions in recursive query |