Re: Parallel Full Hash Join

From: Melanie Plageman <melanieplageman(at)gmail(dot)com>
To: vignesh C <vignesh21(at)gmail(dot)com>
Cc: Greg Nancarrow <gregn4422(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Parallel Full Hash Join
Date: 2021-07-30 20:34:34
Message-ID: CAAKRu_Y7C-XsAy8y7CumcMRjG3t1jsDZskTyUyTkw=jDSQZdgw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Jul 10, 2021 at 9:13 AM vignesh C <vignesh21(at)gmail(dot)com> wrote:
>
> On Mon, May 31, 2021 at 10:47 AM Greg Nancarrow <gregn4422(at)gmail(dot)com> wrote:
> >
> > On Sat, Mar 6, 2021 at 12:31 PM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> > >
> > > On Tue, Mar 2, 2021 at 11:27 PM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> > > > On Fri, Feb 12, 2021 at 11:02 AM Melanie Plageman
> > > > <melanieplageman(at)gmail(dot)com> wrote:
> > > > > I just attached the diff.
> > > >
> > > > Squashed into one patch for the cfbot to chew on, with a few minor
> > > > adjustments to a few comments.
> > >
> > > I did some more minor tidying of comments and naming. It's been on my
> > > to-do-list to update some phase names after commit 3048898e, and while
> > > doing that I couldn't resist the opportunity to change DONE to FREE,
> > > which somehow hurts my brain less, and makes much more obvious sense
> > > after the bugfix in CF #3031 that splits DONE into two separate
> > > phases. It also pairs obviously with ALLOCATE. I include a copy of
> > > that bugix here too as 0001, because I'll likely commit that first, so
> > > I rebased the stack of patches that way. 0002 includes the renaming I
> > > propose (master only). Then 0003 is Melanie's patch, using the name
> > > SCAN for the new match bit scan phase. I've attached an updated
> > > version of my "phase diagram" finger painting, to show how it looks
> > > with these three patches. "scan*" is new.
> >
> > Patches 0002, 0003 no longer apply to the master branch, seemingly
> > because of subsequent changes to pgstat, so need rebasing.
>
> I am changing the status to "Waiting on Author" as the patch does not
> apply on Head.
>
> Regards,
> Vignesh
>
>

Rebased patches attached. I will change status back to "Ready for Committer"

Attachment Content-Type Size
v7-0003-Parallel-Hash-Full-Right-Outer-Join.patch text/x-patch 24.7 KB
v7-0001-Fix-race-condition-in-parallel-hash-join-batch-cl.patch text/x-patch 9.8 KB
v7-0002-Improve-the-naming-of-Parallel-Hash-Join-phases.patch text/x-patch 24.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2021-07-30 20:38:53 Re: Use generation context to speed up tuplesorts
Previous Message Bossart, Nathan 2021-07-30 20:25:19 Re: archive status ".ready" files may be created too early