| From: | Melanie Plageman <melanieplageman(at)gmail(dot)com> |
|---|---|
| To: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Andres Freund <andres(at)anarazel(dot)de>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> |
| Subject: | Re: BitmapHeapScan streaming read user and prelim refactoring |
| Date: | 2024-05-14 19:11:39 |
| Message-ID: | CAAKRu_Y36cRie7XurLGQerYQBev4Wphqe4U72cKtQS2Gu6Br=Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, May 14, 2024 at 2:44 PM Tomas Vondra
<tomas(dot)vondra(at)enterprisedb(dot)com> wrote:
>
> On 5/14/24 20:40, Melanie Plageman wrote:
> > On Tue, May 14, 2024 at 2:33 PM Tomas Vondra
> > <tomas(dot)vondra(at)enterprisedb(dot)com> wrote:
> >>
> >> On 5/14/24 19:42, Melanie Plageman wrote:
> >>> I've fixed this. I've also set enable_material off as I mentioned I
> >>> might in my earlier mail.
> >>>
> >>
> >> I'm not sure this (setting more and more GUCs to prevent hypothetical
> >> plan changes) is a good practice. Because how do you know the plan does
> >> not change for some other unexpected reason, possibly in the future?
> >
> > Sure. So, you think it is better not to have enable_material = false?
> >
>
> Right. Unless it's actually needed to force the necessary plan.
Attached v6 does not use enable_material = false (as it is not needed).
- Melanie
| Attachment | Content-Type | Size |
|---|---|---|
| v6-0001-BitmapHeapScan-Remove-incorrect-assert-and-reset-.patch | text/x-patch | 5.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jacob Burroughs | 2024-05-14 19:22:01 | Re: libpq compression (part 3) |
| Previous Message | Phil Eaton | 2024-05-14 19:02:03 | Re: Add minimal C example and SQL registration example for custom table access methods. |