Re: Add system identifier to backup manifest

On Mon, Jan 22, 2024 at 10:08 AM Amul Sul <sulamul(at)gmail(dot)com> wrote:

>
>
> On Fri, Jan 19, 2024 at 10:36 PM Amul Sul <sulamul(at)gmail(dot)com> wrote:
>
>> On Wed, Jan 17, 2024 at 8:40 PM Robert Haas <robertmhaas(at)gmail(dot)com>
>> wrote:
>>
>>>
>>>
>> Updated version is attached.
>>
>
> Another updated version attached -- fix missing manifest version check in
> pg_verifybackup before system identifier validation.
>

Thinking a bit more on this, I realized parse_manifest_file() has many out
parameters. Instead parse_manifest_file() should simply return manifest data
like load_backup_manifest(). Attached 0001 patch doing the same, and
removed
parser_context structure, and added manifest_data, and did the required
adjustments to pg_verifybackup code.

Regards,
Amul