Re: [Patch] ALTER SYSTEM READ ONLY

On Fri, 20 Nov 2020 at 9:53 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:

> On Thu, Oct 8, 2020 at 6:23 AM Amul Sul <sulamul(at)gmail(dot)com> wrote:
> > On a quick look at the latest 0001 patch, the following hunk to reset
> leftover
> > flags seems to be unnecessary:
> >
> > + /*
> > + * If some barrier types were not successfully absorbed, we will have
> > + * to try again later.
> > + */
> > + if (!success)
> > + {
> > + ResetProcSignalBarrierBits(flags);
> > + return;
> > + }
> >
> > When the ProcessBarrierPlaceholder() function returns false without an
> error,
> > that barrier flag gets reset within the while loop. The case when it
> has an
> > error, the rest of the flags get reset in the catch block. Correct me
> if I am
> > missing something here.
>
> Good catch. I think you're right. Do you want to update accordingly?

Sure, Ill update that. Thanks for the confirmation.

> Andres, do you like the new loop better?
>
> --
> Robert Haas
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>