From: | Amul Sul <sulamul(at)gmail(dot)com> |
---|---|
To: | Euler Taveira <euler(at)eulerto(dot)com> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: TAP test for recovery_end_command |
Date: | 2021-09-13 13:09:13 |
Message-ID: | CAAJ_b95p69s7j=gZi6w6oqc7aZB0EXnoceUF4f7oaotdwa9beQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, Sep 13, 2021 at 5:56 AM Euler Taveira <euler(at)eulerto(dot)com> wrote:
>
> On Thu, Sep 9, 2021, at 8:18 AM, Amul Sul wrote:
>
> The attached patch adds a small test for recovery_end_command execution.
>
> Additional coverage is always a good thing.
>
Thanks for the confirmation.
> Currently, patch tests execution of recovery_end_command by creating
> dummy file, I am not wedded only to this approach, other suggestions
> also welcome.
>
> This test file is for archiving only. It seems 020_archive_status.pl is more
> appropriate for testing this parameter.
>
Ok, moved to 020_archive_status.pl in the attached version.
> Also, we don't have a good test for archive_cleanup_command as well, I
> am not sure how we could test that which executes with every
> restart-point.
>
> Setup a replica and stop it. It triggers a restartpoint during the shutdown.
Yeah, added that test too. I triggered the restartpoint via a
CHECKPOINT command in the attached version.
Note that I haven't tested the current version on Windows, will
cross-check that tomorrow.
Regards,
Amul
Attachment | Content-Type | Size |
---|---|---|
TAP-test_recovery_end_command_v2.patch | application/x-patch | 2.1 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Justin Pryzby | 2021-09-13 13:11:52 | Re: proposal: possibility to read dumped table's name from file |
Previous Message | Daniel Gustafsson | 2021-09-13 13:04:28 | Re: [PATCH] test/ssl: rework the sslfiles Makefile target |