Re: CREATE SEQUENCE with RESTART option

From: Amul Sul <sulamul(at)gmail(dot)com>
To: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
Cc: Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: CREATE SEQUENCE with RESTART option
Date: 2021-04-08 04:38:35
Message-ID: CAAJ_b95m-JFZueJtQNuLqv7i24gmWDoO4+sJJWBUsdkAw+=9dA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Apr 7, 2021 at 6:52 PM Bharath Rupireddy
<bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
>
> On Wed, Apr 7, 2021 at 6:04 PM Ashutosh Bapat
> <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> wrote:
> > At best CREATE SEQUENCE .... START ... RESTART ... can be a shorthand
> > for CREATE SEQUENCE ... START; ALTER SEQUENCE ... RESTART run back to
> > back. So it looks useful but in rare cases.
>
> I personally feel that let's not mix up START and RESTART in CREATE
> SEQUENCE. If required, users will run ALTER SEQUENCE RESTART
> separately, that will be a clean way.
>
> > Said all that I agree that if we are supporting CREATE SEQUENCE ...
> > RESTART then we should document it, correctly. If that's not the
> > intention, we should disallow RESTART with CREATE SEQUENCE.
>
> As I mentioned upthread, it's better to disallow (throw error) if
> RESTART is specified for CREATE SEQUENCE. Having said that, I would
> like to hear from others.
>

FWIW, +1.

The RESTART clause in the CREATE SEQUENCE doesn't make sense
to me, it should be restricted, IMO.

Regards,
Amul

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kohei KaiGai 2021-04-08 04:43:25 Re: TRUNCATE on foreign table
Previous Message Julien Rouhaud 2021-04-08 04:17:58 Re: Feature improvement: can we add queryId for pg_catalog.pg_stat_activity view?