| From: | Amul Sul <sulamul(at)gmail(dot)com> |
|---|---|
| To: | Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Peter Eisentraut <peter(at)eisentraut(dot)org>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, jian he <jian(dot)universality(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Joel Jacobson <joel(at)compiler(dot)org>, Alexandra Wang <alexandra(dot)wang(dot)oss(at)gmail(dot)com>, Suraj Kharage <suraj(dot)kharage(at)enterprisedb(dot)com> |
| Subject: | Re: NOT ENFORCED constraint feature |
| Date: | 2025-03-27 04:48:46 |
| Message-ID: | CAAJ_b959mAJog0CecwT9v=2n2U3zSN0vJeRBT5U6zNsEhqyO+w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Mar 26, 2025 at 12:29 PM Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
>
> On 2025-Mar-26, Amul Sul wrote:
>
> > The reason for the change is to revert to the behavior before commit
> > #80d7f990496b1c, where recursion occurred regardless of the
> > changed flags. This is also described in the header comment for
> > ATExecAlterConstrDeferrability() (earlier it was for
> > ATExecAlterConstraintInternal):
> >
> > * Note that we must recurse even when the values are correct, in case
> > * indirect descendants have had their constraints altered locally.
> > * (This could be avoided if we forbade altering constraints in partitions
> > * but existing releases don't do that.)
>
> Umm, why? Surely we should not allow a partition tree to become
> inconsistent.
>
I just checked, and we are not allowed to alter a constraint on the
child table alone, nor can we merge it when attaching to the parent
constraint if the deferrability is different. Therefore, I think we
should remove this comment as it seems outdated now.
Regards,
Amul
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ajin Cherian | 2025-03-27 04:57:58 | Re: Historic snapshot doesn't track txns committed in BUILDING_SNAPSHOT state |
| Previous Message | Ashutosh Bapat | 2025-03-27 04:42:46 | Re: [PoC] Reducing planning time when tables have many partitions |