| From: | Amul Sul <sulamul(at)gmail(dot)com> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: CI cpluspluscheck failures |
| Date: | 2024-08-20 04:53:58 |
| Message-ID: | CAAJ_b94GQYPmoiBPocm+c0vv+TB6975u+_BNNd7HrvrDKW0DEQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Aug 19, 2024 at 1:30 AM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
>
> On Mon, Aug 19, 2024 at 12:10 AM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> > I'm not sure why the first one started happening at the commit
> > (aa2d6b15) that caused the second one, I feel like I'm missing
> > something...
Thanks, Thomas, for addressing the missing include.
Adding logging.h to the pg_verifybackup.h file makes it redundant in
pg_verifybackup.c. The attached patch proposes removing this redundant
include from pg_verifybackup.c, along with a few other unnecessary
includes.
Regards,
Amul
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Remove-unnecessary-include-statements.patch | application/x-patch | 782 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bertrand Drouvot | 2024-08-20 05:19:56 | Re: define PG_REPLSLOT_DIR |
| Previous Message | Michael Paquier | 2024-08-20 04:46:03 | Remaining reference to _PG_fini() in ldap_password_func |