| From: | Amul Sul <sulamul(at)gmail(dot)com> |
|---|---|
| To: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, "Bossart, Nathan" <bossartn(at)amazon(dot)com>, Jakub(dot)Wartak(at)tomtom(dot)com, Ryo Matsumura <matsumura(dot)ryo(at)fujitsu(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, mengjuan(dot)cmj(at)alibaba-inc(dot)com, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: prevent immature WAL streaming |
| Date: | 2021-10-25 05:04:27 |
| Message-ID: | CAAJ_b94ATi4g_PFwrMn07HO=FYk-rgzU4UxyHHPwhN6FHq5u=A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Oct 25, 2021 at 7:02 AM Kyotaro Horiguchi
<horikyota(dot)ntt(at)gmail(dot)com> wrote:
>
> At Fri, 22 Oct 2021 18:43:52 +0530, Amul Sul <sulamul(at)gmail(dot)com> wrote in
> > Any thoughts about the patch posted previously?
>
> Honestly, xlogreader looks fine with the current shape. The reason is
> that it seems cleaner as an interface boundary since the caller of
> xlogreader doesn't need to know about the details of xlogreader. The
> current code nicely hides the end+1 confusion.
>
> Even if we want to get rid of global variables in xlog.c, I don't
> understand why we remove only abortedRecPtr. That change makes things
> more complex as a whole by letting xlog.c be more conscious of
> xlogreader's internals. I'm not sure I like that aspect of the patch.
>
Because we have other ways to get abortedRecPtr without having a
global variable, but we don't have such a way for missingContrecPtr,
AFAICU.
I agree using global variables makes things a bit easier, but those
are inefficient when you want to share those with other processes --
that would add extra burden to shared memory.
Regards,
Amul
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2021-10-25 05:22:37 | Re: Added schema level support for publication. |
| Previous Message | Bharath Rupireddy | 2021-10-25 04:27:52 | Re: Allow pg_signal_backend members to use pg_log_backend_memory_stats(). |