From: | John McKown <john(dot)archie(dot)mckown(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Vik Fearing <vik(at)2ndquadrant(dot)fr>, Josh Berkus <josh(at)agliodbs(dot)com>, pgsql-bugs <pgsql-bugs(at)postgresql(dot)org> |
Subject: | Re: DOS-style line endings in .pgpass |
Date: | 2016-11-14 20:19:12 |
Message-ID: | CAAJSdjhtocaJ=53H5==MQ5_bbcrK9yuk0842LPZA990GZMKe+w@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs |
On Mon, Nov 14, 2016 at 2:10 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Vik Fearing <vik(at)2ndquadrant(dot)fr> writes:
> > On 11/14/2016 08:31 PM, Josh Berkus wrote:
> >> What appears to be happening here is that one of the characters of the
> >> CRLF is being appended to the password, making it invalid.
>
> > Maybe something like the attached patch?
>
> Our usual approach to \r characters is that they're whitespace. I wonder
> whether the most friendly solution here is to chomp all trailing
> whitespace. Anybody ever heard of using a trailing space or tab in a
> password?
>
> while (len > 0 && strchr(" \t\r\n", buf[len - 1]) != NULL)
> buf[--len] = '\0';
>
> regards, tom lane
FWIW, I think that's a really good idea. I, personally, don't like
non-printable characters in passwords. They are harder than <elided> to
enter on the keyboard.
>
>
--
Heisenberg may have been here.
Unicode: http://xkcd.com/1726/
Maranatha! <><
John McKown
From | Date | Subject | |
---|---|---|---|
Next Message | Vik Fearing | 2016-11-15 01:07:48 | Re: DOS-style line endings in .pgpass |
Previous Message | Tom Lane | 2016-11-14 20:10:49 | Re: DOS-style line endings in .pgpass |