| From: | Zheng Li <zhengli10(at)gmail(dot)com> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, "Wei Wang (Fujitsu)" <wangw(dot)fnst(at)fujitsu(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com>, "Yu Shi (Fujitsu)" <shiy(dot)fnst(at)fujitsu(dot)com>, "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, Ajin Cherian <itsajin(at)gmail(dot)com>, Runqi Tian <runqidev(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, li jie <ggysxcq(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Japin Li <japinli(at)hotmail(dot)com>, rajesh singarapu <rajesh(dot)rs0541(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Support logical replication of DDLs |
| Date: | 2023-07-09 19:22:05 |
| Message-ID: | CAAD30UKv-VYyd2DBt-RzG9eL3V_E4tbGWmTYpvLjmzyT4ikVAQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-general pgsql-hackers |
On Tue, Jun 27, 2023 at 6:16 AM vignesh C <vignesh21(at)gmail(dot)com> wrote:
> While development, below are some of the challenges we faced:
> 1. Almost all the members of the AlterTableType enum will have to be annotated.
> 2. Complex functionalities which require access to catalog tables
> cannot be auto generated, custom functions should be written in this
> case.
> 3. Some commands might have completely custom code(no auto generation)
> and in the alter/drop table case we will have hybrid implementation
> both auto generated and custom implementation.
Thanks for providing the PoC for auto generation of the deparser code!
I think this is the main difference between the deparser code and outfuncs.c.
There is no need for catalog access in outfuncs.c, which makes code generation
simpler for outfuncs.c and harder for the deparser. The hybrid
implementation of the deparser doesn't seem
to make it more maintainable, it's probably more confusing. Is it possible to
automate the code with catalog access? There may be common patterns in it also.
Regards,
Zane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Lorusso Domenico | 2023-07-09 20:47:51 | Re: How to add function schema in search_path in option definitio |
| Previous Message | Avi Weinberg | 2023-07-09 14:22:37 | Problematic enforcement of "ERROR: functions in index predicate must be marked IMMUTABLE" |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2023-07-09 21:44:57 | Re: BRIN indexes vs. SK_SEARCHARRAY (and preprocessing scan keys) |
| Previous Message | reid.thompson | 2023-07-09 19:11:22 | Re: DecodeInterval fixes |