Re: Alias of VALUES RTE in explain plan

On Mon, Oct 28, 2024 at 8:16 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:

> Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> writes:
> > The patch looks good to me, except the name of the new member.
>
> > CommonTableExpr *p_parent_cte; /* this query's containing CTE */
> > + Alias *p_parent_alias; /* parent's alias for this query */
>
> > the two "parent"s here mean different things and that might lead one
> > to assume that the p_parent_alias refers to alias of CTE. The comment
> > adds to the confusion since it mentions parent. How about renaming it
> > as p_outer_alias? or something which indicates alias of the outer
> > query?
>
> Hmm, I figured the two "parent" references do mean the same thing,
> ie the immediately surrounding syntactic construct. While I won't
> fight hard about it, I don't see an advantage in naming the new
> field differently. We could make the comment be
>
> /* outer level's alias for this query */

This seems ok to me.

> if that helps any.
>
> regards, tom lane
>