Re: Ignore Visual Studio's Temp Files While Working with PG on Windows

From: Yasir <yasir(dot)hussain(dot)shah(at)gmail(dot)com>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Josef Šimánek <josef(dot)simanek(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Ignore Visual Studio's Temp Files While Working with PG on Windows
Date: 2024-05-18 21:41:39
Message-ID: CAA9OW9eE=VN615Uxyr64yYJ63dTGXkx4BR0=GhKThZrCraEQ8w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Sun, May 19, 2024 at 2:35 AM Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:

>
> On 2024-05-18 Sa 16:54, Yasir wrote:
>
>
>
> On Sun, May 19, 2024 at 1:45 AM Andrew Dunstan <andrew(at)dunslane(dot)net>
> wrote:
>
>>
>> On 2024-05-18 Sa 15:43, Yasir wrote:
>>
>>
>>
>> On Sat, May 18, 2024 at 7:27 PM Josef Šimánek <josef(dot)simanek(at)gmail(dot)com>
>> wrote:
>>
>>> pá 17. 5. 2024 v 8:09 odesílatel Yasir <yasir(dot)hussain(dot)shah(at)gmail(dot)com>
>>> napsal:
>>> >
>>> > Hi Hackers,
>>> >
>>> > I have been playing with PG on the Windows platform recently. An
>>> annoying thing I faced is that a lot of Visual Studio's temp files kept
>>> appearing in git changed files. Therefore, I am submitting this very
>>> trivial patch to ignore these temp files.
>>>
>>> see
>>> https://docs.github.com/en/get-started/getting-started-with-git/ignoring-files#configuring-ignored-files-for-all-repositories-on-your-computer
>>> for various strategies
>>>
>>>
>> We can add it to "~/.config/git/ignore" as it will ignore globally on
>> windows which we don't want. Also we don't have ".git/info/exclude" in PG
>> project's so the best place left is projects's .gitignore. That's what was
>> patched.
>>
>>
>>
>>
>> eh? git creates .git/info/exclude in every git repository AFAIK. And it's
>> referred to here: <https://git-scm.com/docs/gitignore>
>> <https://git-scm.com/docs/gitignore>
>>
>>
>> Yes, git creates .git/info/exclude but point is, it is not in PG
> maintained codebase repo. So, no point adding to it.
>
> BTW, Tom and Peter said it's not going to be added anyway!
>
>
>>
>>
> You've completely missed my point, which is that *you* should be adding it
> to that file, as an alternative to using a (locally) global gitignore file.
>
My bad Andrew.

> I agree with Tom and Peter.
>
>
> cheers
>
>
> andrew
>
> --
> Andrew Dunstan
> EDB: https://www.enterprisedb.com
>
>

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2024-05-18 21:43:40 pgsql: doc PG 17 relnotes: update to current
Previous Message Andrew Dunstan 2024-05-18 21:35:04 Re: Ignore Visual Studio's Temp Files While Working with PG on Windows

Browse pgsql-hackers by date

  From Date Subject
Next Message Noah Misch 2024-05-18 21:45:46 Re: pg_trgm comparison bug on cross-architecture replication due to different char implementation
Previous Message Bruce Momjian 2024-05-18 21:37:29 Re: First draft of PG 17 release notes