From: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> |
---|---|
To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: pgsql: Add a non-strict version of jsonb_set |
Date: | 2020-01-17 23:12:12 |
Message-ID: | CAA8=A79P1E727WU2L27Dx7LardkxjJAecCc0gBmj-hzWtdthpg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
On Fri, Jan 17, 2020 at 1:50 PM Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>
>
>
>
>
> > On Jan 17, 2020, at 12:44 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> >
> > Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> >> Add a non-strict version of jsonb_set
> >
> > Shoulda been a catversion bump in here, if only for protocol's sake.
> >
> > (A useful rule of thumb is "if you won't pass the regression tests
> > without doing an initdb, there should be a catversion change".)
> >
> >
>
> Argh! Will fix when back at my desk
>
I'd love to have a git pre-commit hook that would warn about this, it
seems to happen several times a year, and I know I've transgressed
more than once. Not sure what the rules should be, something like if
you changed src/include/catalog/* but not
src/include/catalog/catversion.h ?
cheers
andrew
--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2020-01-17 23:41:02 | Re: pgsql: Add a non-strict version of jsonb_set |
Previous Message | Alexander Korotkov | 2020-01-17 22:11:59 | pgsql: Avoid full scan of GIN indexes when possible |