| From: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Disabling src/test/[ssl|ldap] when not building with SSL/LDAP support |
| Date: | 2018-02-12 23:34:52 |
| Message-ID: | CAA8=A7947iRUy3ZtZY4f2pgnLqy-i_+XVWEcDTugr0Tv7WHcYg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Feb 10, 2018 at 2:02 PM, Thomas Munro
<thomas(dot)munro(at)enterprisedb(dot)com> wrote:
> I agree that it would be nice if the build farm (and my unofficial
> patch tester for that matter) could automatically test the LDAP stuff
> when running on a suitable system, but I think it would need to be
> based not just on ifeq ($(with_ldap),yes) as you showed. I think the
> test would need a way to report that it can't find slapd so it can't
> run, but not consider that to be a hard failure. Or something like
> that...
I think we could do that in the buildfarm by providing an
extra_tap_tests config setting. It would be up to the owner to ensure
that there was a suitable test environment available.
cheers
andrew
--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-02-12 23:38:36 | Re: rename sgml files? |
| Previous Message | David Fetter | 2018-02-12 23:31:14 | Re: rename sgml files? |