| From: | Sami Imseih <samimseih(at)gmail(dot)com> |
|---|---|
| To: | Alena Rybakina <a(dot)rybakina(at)postgrespro(dot)ru> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Andrei Lepikhov <lepihov(at)gmail(dot)com>, Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Lukas Fittl <lukas(at)fittl(dot)com> |
| Subject: | Re: Proposal - Allow extensions to set a Plan Identifier |
| Date: | 2025-03-24 19:31:17 |
| Message-ID: | CAA5RZ0vsNS91bYu_EkPHweawz5OAxfWC-+gXBmMoCbzXrcRQKQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> Hi! I started reviewing it and noticed that your code repeated this
> cycle maybe it would be better to put it in a separate function, for
> example in the form of a name like "analyze_stmts"?
>
> or is it possible to create a macro for them?
Perhaps it may be better to stick this all in a macro,
but I did it that way because we have similar
pattern for queryId, with some repeating patterns for
looping through a list of Query or PlannedStmt.
As this patch already got committed, feel free to
propose a patch for this improvement.
--
Sami Imseih
Amazon Web Services (AWS)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Rahila Syed | 2025-03-24 19:31:36 | Re: Prevent an error on attaching/creating a DSM/DSA from an interrupt handler. |
| Previous Message | Nikolay Shaplov | 2025-03-24 19:30:41 | Re: vacuum_truncate configuration parameter and isset_offset |