| From: | Sami Imseih <samimseih(at)gmail(dot)com> |
|---|---|
| To: | Lukas Fittl <lukas(at)fittl(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Andrei Lepikhov <lepihov(at)gmail(dot)com>, Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Proposal - Allow extensions to set a Plan Identifier |
| Date: | 2025-04-02 19:43:13 |
| Message-ID: | CAA5RZ0voqdPZ750pGn4d6umJh9tdM6y8Zg3mqudtLmCV0EUGaQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> I reviewed the patch and I only have one comment. I still think
> we need an Assert inside RecordConstantLocation to make sure clocations
> is allocated if the caller intends to record constant locations.
>
> RecordConstLocation(JumbleState *jstate, int location, bool squashed)
> {
> + Assert(jstate->clocations);
> +
Here is v3 with the Assert in place
--
Sami Imseih
Amazon Web Services (AWS)
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Allow-plugins-to-Jumble-an-expression.patch | application/octet-stream | 11.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Arseniy Mukhin | 2025-04-02 19:50:01 | Re: LWLock deadlock in brinRevmapDesummarizeRange |
| Previous Message | Heikki Linnakangas | 2025-04-02 19:41:48 | Re: [PATCH] Add sortsupport for range types and btree_gist |