| From: | Sami Imseih <samimseih(at)gmail(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Jeff Davis <pgsql(at)j-davis(dot)com>, Thom Brown <thom(at)linux(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: making EXPLAIN extensible |
| Date: | 2025-03-19 17:41:36 |
| Message-ID: | CAA5RZ0vOcJF91O2e5AQN+V6guMNLMhJx83dxALf-iUZ-hLGO_Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Wed, Mar 19, 2025 at 11:38 AM Sami Imseih <samimseih(at)gmail(dot)com> wrote:
> > ... as I made the hook signature match that of
> > ParseExplainOptionList, so both pstate and the options list
> > are now available to the hook.
>
> This version LGTM, except it's not pgindent-clean.
ugh, sorry about that. ran it for both modified files and it found one
indentation correction from v2.
> index 1d4be3c18ac..8fe1ca5c73e 100644
38c38
< + (*explain_validate_options_hook) (es, options, pstate);
---
> + (*explain_validate_options_hook)(es, options, pstate);
59c59
< 2.47.1
v3 attached.
--
Sami Imseih
Amazon Web Services (AWS)
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Add-new-hooks-for-performing-additional-EXPLAIN-o.patch | application/octet-stream | 2.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Rafael Thofehrn Castro | 2025-03-19 17:46:56 | Re: Proposal: Progressive explain |
| Previous Message | Jeff Davis | 2025-03-19 17:39:29 | Re: Update Unicode data to Unicode 16.0.0 |