| From: | Sami Imseih <samimseih(at)gmail(dot)com> |
|---|---|
| To: | Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Christoph Berg <myon(at)debian(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Michael Paquier <michael(at)paquier(dot)xyz>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com> |
| Subject: | Re: Squash constant lists in query jumbling by default |
| Date: | 2025-03-25 17:55:58 |
| Message-ID: | CAA5RZ0v5VqUo_ew-fNA1HDF4Lo=7UtEyoT_SYOPjYFcjmDfE2Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
> > If this GUC sticks around, it should be at least PGC_SUSET (on
> > the analogy of compute_query_id) to make it harder to break
> > pg_stat_statements that way.
>
> I have no problem making it superuser-only, and I can see making "on" be
> the default. I am not opposed to removing it completely either, if we
> really think that the current behavior is no longer useful for anybody.
I am in favor of complete removal. [1] will change the behavior of table
jumbling without introducing a GUC, and I don't think we should introduce
a GUC for the squash values case either. Why one behavior change is configurable
while the other is not? seems confusing, IMO.
Also, as a matter of principle, it seems most are favoring not
introducing GUCs to
configure queryId behavior. I agree.
--
Sami Imseih
Amazon Web Services (AWS)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeff Davis | 2025-03-25 18:19:18 | pgsql: Minor doc update for commit 99f8f3fbbc. |
| Previous Message | Álvaro Herrera | 2025-03-25 17:27:57 | Re: Squash constant lists in query jumbling by default |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dmitry Dolgov | 2025-03-25 18:40:01 | Re: Squash constant lists in query jumbling by default |
| Previous Message | Robert Treat | 2025-03-25 17:51:17 | Re: Statistics Import and Export |