Re: pgsql: Trial fix for old cross-version upgrades.

From: Sami Imseih <samimseih(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, Jeff Davis <pgsql(at)j-davis(dot)com>, Jeff Davis <jdavis(at)postgresql(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Trial fix for old cross-version upgrades.
Date: 2025-02-28 19:29:16
Message-ID: CAA5RZ0tz-AibaxVF1NnNMcMEmwut+kn=k=xG2XmDN9d6kv2-=g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

My perl expertise is bit shallow, but I could not find much
regarding bugs related to such behavior, or maybe I did not
look enough.

Playing around with this, "s+", "s{1,}", s{2,}" all of these combinations
where we are searching for more than 1 space result in the hanging command,
but we really only need to look for a single space before the 'version',
so maybe we can just do the below, which works?

- $dump =~ s {(^\s+'version',) '\d+'::integer,$}
+ $dump =~ s {(^\s{1}'version',) '\d+'::integer,$}

--
Sami

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2025-02-28 19:29:28 Re: pgsql: Trial fix for old cross-version upgrades.
Previous Message Sami Imseih 2025-02-28 18:39:59 Re: pgsql: Trial fix for old cross-version upgrades.