| From: | Sami Imseih <samimseih(at)gmail(dot)com> |
|---|---|
| To: | Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Kirill Reshke <reshkekirill(at)gmail(dot)com>, Sergei Kornilov <sk(at)zsrv(dot)org>, yasuo(dot)honda(at)gmail(dot)com, tgl(at)sss(dot)pgh(dot)pa(dot)us, smithpb2250(at)gmail(dot)com, vignesh21(at)gmail(dot)com, michael(at)paquier(dot)xyz, nathandbossart(at)gmail(dot)com, stark(dot)cfm(at)gmail(dot)com, geidav(dot)pg(at)gmail(dot)com, marcos(at)f10(dot)com(dot)br, robertmhaas(at)gmail(dot)com, david(at)pgmasters(dot)net, pgsql-hackers(at)postgresql(dot)org, pavel(dot)trukhanov(at)gmail(dot)com, Sutou Kouhei <kou(at)clear-code(dot)com> |
| Subject: | Re: pg_stat_statements and "IN" conditions |
| Date: | 2025-02-11 16:49:59 |
| Message-ID: | CAA5RZ0tbcQoFmMCQh3nNSg5dKsuepa9-uTfYXTMXxdU+Xi9KhA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I have only looked at 0001, but I am wondering why
query_id_const_merge is a pg_stat_statements GUC
rather than a core GUC?
The dependency of pg_stat_statements to take advantage
of this useful feature does not seem right.
For example if the user does not have pg_stat_statements enabled,
but are sampling top queryId from pg_stat_activity, they will
likely want this merge behavior to build meaningful database
load graphs.
Other extensions that consume queryIds may also want this
behavior without needing to enable pg_stat_statements.
Also, we have compute_query_id as a core parameter, this
new guc will become an option for how to compute a queryId.
In the future we may want to introduce other controls for how a
queryId is generated.
Regards,
Sami
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2025-02-11 16:53:37 | Re: [PATCH] snowball: fix potential NULL dereference |
| Previous Message | Euler Taveira | 2025-02-11 16:32:32 | Re: Small memory fixes for pg_createsubcriber |