| From: | Sami Imseih <samimseih(at)gmail(dot)com> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | Robert Treat <rob(at)xzilla(dot)net>, Frédéric Yhuel <frederic(dot)yhuel(at)dalibo(dot)com>, wenhui qiu <qiuwenhuifx(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, "Imseih (AWS), Sami" <simseih(at)amazon(dot)com>, David Rowley <dgrowleyml(at)gmail(dot)com>, Joe Conway <mail(at)joeconway(dot)com>, Michael Banck <mbanck(at)gmx(dot)net>, Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, Melanie Plageman <melanieplageman(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: New GUC autovacuum_max_threshold ? |
| Date: | 2025-01-13 23:17:11 |
| Message-ID: | CAA5RZ0tAqjtJz+2=S1LvDUJfrpGa73nmLccwvr_R1r8CC4HmaA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> Here is a rebased version of the patch (commit ca9c6a5 adjusted the
> documentation for vacuum-related GUCs).
I looked at the patch and have a few comments.
I propose renaming the GUC from "autovacuum_max_threshold" to
"autovacuum_vacuum_max_threshold" to clarify that it applies only
to the vacuum operation performed by autovacuum, not to the analyze operation.
This will also align with naming for other related GUCs, i.e.,
"autovacuum_analyze_threshold" and "autovacuum_vacuum_threshold."
The "vacuum threshold" calculation described in [1] will also need to be
updated.
[1] https://www.postgresql.org/docs/current/routine-vacuuming.html#AUTOVACUUM
Regards,
Sami
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jacob Champion | 2025-01-13 23:21:31 | Re: [PoC] Federated Authn/z with OAUTHBEARER |
| Previous Message | Tom Lane | 2025-01-13 22:51:54 | Re: pgbench error: (setshell) of script 0; execution of meta-command failed |