Re: Introduce XID age and inactive timeout based replication slot invalidation

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Nathan Bossart <nathandbossart(at)gmail(dot)com>
Cc: "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Ajin Cherian <itsajin(at)gmail(dot)com>, Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Introduce XID age and inactive timeout based replication slot invalidation
Date: 2025-02-19 10:13:30
Message-ID: CAA4eK1LywgEnW+crAPNU+JCBUrXq0Aafkaa+V2y1RWMaSpp-SQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Feb 18, 2025 at 8:42 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Mon, Feb 17, 2025 at 10:18 PM Nathan Bossart
> <nathandbossart(at)gmail(dot)com> wrote:
> >
> > On Mon, Feb 17, 2025 at 07:57:22AM +0530, Amit Kapila wrote:
> >
> > > Alvaro, Nathan, do let us know if you would like to discuss more on
> > > the use case for this new GUC idle_replication_slot_timeout?
> > > Otherwise, we can proceed with this patch.
> >
> > I guess I'm not mortally opposed to it. I just think we really need
> > proper backstops against the storage/XID issues more than we need this one,
> > and I don't want it to be mistaken for a solution to those problems.
> >
>
> Fair enough. I see your point and would like to discuss the other
> parameter in a separate thread. I plan to push the 0001 tomorrow after
> some more review/testing unless I see any further arguments or
> comments.
>

Pushed after minor modifications.

--
With Regards,
Amit Kapila.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ayush Vatsa 2025-02-19 10:23:48 Re: Clarification on Role Access Rights to Table Indexes
Previous Message Alexander Korotkov 2025-02-19 10:00:51 Re: Improve statistics estimation considering GROUP-BY as a 'uniqueiser'