| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Jeff Davis <pgsql(at)j-davis(dot)com> |
| Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de> |
| Subject: | Re: Question about StartLogicalReplication() error path |
| Date: | 2021-06-19 10:00:08 |
| Message-ID: | CAA4eK1LyM9JbTNH_HQ0Sh7Gim0tGi1HbM5SqH7sHkp4mqi8adQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jun 17, 2021 at 4:25 AM Jeff Davis <pgsql(at)j-davis(dot)com> wrote:
>
> On Tue, 2021-06-15 at 15:19 +0900, Kyotaro Horiguchi wrote:
> > I don't think the message is neded, but I don't oppose it as far as
> > the level is LOG and the messages were changed as something like
> > this:
> >
> >
> > - elog(DEBUG1, "cannot stream from %X/%X, minimum is
> > %X/%X, forwarding",
> > + elog(LOG, "%X/%X has been already streamed,
> > forwarding to %X/%X",
> >
> > FWIW, I most prefer #1. I see #2 as optional. and see #3 as the
> > above.
>
> Attached.
>
LGTM.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2021-06-19 10:14:19 | Re: Unresolved repliaction hang and stop problem. |
| Previous Message | Amit Kapila | 2021-06-19 09:51:05 | Re: locking [user] catalog tables vs 2pc vs logical rep |