Re: [PATCH v1] eliminate duplicate code in table.c

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Aleksander Alekseev <aleksander(at)timescale(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Junwang Zhao <zhjwpku(at)gmail(dot)com>
Subject: Re: [PATCH v1] eliminate duplicate code in table.c
Date: 2022-07-21 13:47:21
Message-ID: CAA4eK1Ly32xGJHN-=0vAxz7UqXisvqrSDiB0fXByHUeh1SdF2Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jul 21, 2022 at 6:12 PM Aleksander Alekseev
<aleksander(at)timescale(dot)com> wrote:
>
> Hi Alvaro,
>
> > Hmm, but see commit 2ed532ee8c47 about this kind of check. Perhaps we
> > should change these error messages to conform to the same message style.
>
> Good point! Done.
>

Yeah, that's better. On again thinking about the function name, I
wonder if validate_relation_type() suits here as there is no generic
object being passed?

--
With Regards,
Amit Kapila.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2022-07-21 13:48:18 Re: System catalog documentation chapter
Previous Message Tom Lane 2022-07-21 13:46:05 Re: Remove fls(), use pg_bitutils.h facilities instead?