| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Vitaly Davydov <v(dot)davydov(at)postgrespro(dot)ru>, Ajin Cherian <itsajin(at)gmail(dot)com> |
| Subject: | Re: Slow catchup of 2PC (twophase) transactions on replica in LR |
| Date: | 2024-07-19 06:24:56 |
| Message-ID: | CAA4eK1LtqMcsAW_H4JtmyZ-i9yF3fOVUKhXoVpc5NS5LNuN4iQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jul 19, 2024 at 10:45 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> > ======
> > src/include/replication/slot.h
> >
> > 1.
> > -extern void ReplicationSlotAlter(const char *name, bool failover);
> > +extern void ReplicationSlotAlter(const char *name, bool *failover,
> > + bool *two_phase);
> >
> > Use const?
> >
>
> If so, we need to use const both for failover and two_phase but not
> sure if that is required here. We can evaluate that separately if
> required by comparing it with similar instances.
>
I checked and found that the patch uses const in walrcv_alter_slot_fn,
so agree that we can change to const here as well.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | jian he | 2024-07-19 06:55:00 | Re: documentation structure |
| Previous Message | Sutou Kouhei | 2024-07-19 06:10:31 | Re: Fixing backslash dot for COPY FROM...CSV |