| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Greg Nancarrow <gregn4422(at)gmail(dot)com> |
| Cc: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>, "osumi(dot)takamichi(at)fujitsu(dot)com" <osumi(dot)takamichi(at)fujitsu(dot)com>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, Alexey Lesovsky <lesovsky(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Skipping logical replication transactions on subscriber side |
| Date: | 2021-08-26 03:51:30 |
| Message-ID: | CAA4eK1LnV=J_LqGo+Go-5BHRPu4j+UdwKQXhAOFgCo8t8VachQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Aug 26, 2021 at 7:15 AM Greg Nancarrow <gregn4422(at)gmail(dot)com> wrote:
>
> On Wed, Aug 25, 2021 at 2:22 PM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> >
> > Attached updated version patches. Please review them.
> >
>
> Regarding the v11-0001 patch, it looks OK to me, but I do have one point:
> In apply_dispatch(), wouldn't it be better to NOT move the error
> reporting for an invalid message type into the switch as the default
> case - because then, if you add a new message type, you won't get a
> compiler warning (when warnings are enabled) for a missing switch
> case, which is a handy way to alert you that the new message type
> needs to be added as a case to the switch.
>
Do you have any suggestions on how to achieve that without adding some
additional variable? I think it is not a very hard requirement as we
don't follow the same at other places in code.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2021-08-26 03:54:08 | Re: Failure of subscription tests with topminnow |
| Previous Message | Ajin Cherian | 2021-08-26 03:51:06 | Re: Failure of subscription tests with topminnow |