From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
---|---|
To: | James Coleman <jtc331(at)gmail(dot)com> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [DOC] Document auto vacuum interruption |
Date: | 2019-09-17 06:21:34 |
Message-ID: | CAA4eK1LmXfBw_g9ymCzvvNqWXUqFebqEewtfpTmzY5Wt-hvJ4A@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Sep 13, 2019 at 11:59 PM James Coleman <jtc331(at)gmail(dot)com> wrote:
>
> On Sat, Aug 31, 2019 at 10:51 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> >
>
> Updated patch attached. I changed the wording to be about conflicting
> locks rather than a single lock type, added a link to the conflicting
> locks table, and fixed a few sgml syntax issues in the original.
>
I see error while compiling this patch on HEAD. See the below error:
/usr/bin/xmllint --path . --noout --valid postgres.sgml
postgres.sgml:833: element xref: validity error : IDREF attribute
linkend references an unknown ID
"mvcc-locking-tables-table-lock-compatibility"
make: *** [check] Error 4
The tag id mvcc-locking-tables-table-lock-compatibility is wrong. The
other problem I see is the wrong wording in one of the literals. I
have fixed both of these issues and slightly tweaked one of the
sentence. See the updated patch attached. On which version, are you
preparing this patch? I see both HEAD and 9.4 has the problems fixed
by me.
Let me know what you think of attached? I think we can back-patch
this patch. What do you think? Does anyone else have an opinion on
this patch especially if we see any problem in back-patching this?
--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
Attachment | Content-Type | Size |
---|---|---|
autovacuum-interruption-v3.patch | application/octet-stream | 2.1 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Etsuro Fujita | 2019-09-17 06:45:57 | Documentation updates for direct foreign table modification |
Previous Message | Michael Paquier | 2019-09-17 05:25:20 | Re: [PATCH] Speedup truncates of relation forks |