Re: Column Filtering in Logical Replication

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>
Cc: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, Rahila Syed <rahilasyed90(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Column Filtering in Logical Replication
Date: 2022-02-16 09:30:29
Message-ID: CAA4eK1LkZhtMQet0utvjOQZff+n1yYREkFb+P=R_7cMkoab+OA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Feb 16, 2022 at 6:09 AM Tomas Vondra
<tomas(dot)vondra(at)enterprisedb(dot)com> wrote:
>
> On 2/16/22 01:33, Alvaro Herrera wrote:
> >
> >> 3) partitioning with pubivaroot=false
> >>
> >> When a partitioned table is added with (pubviaroot=false), it should not be
> >> subject to column filter on the parent relation, which is the same behavior
> >> used by the row filtering patch.
> >
> > You mean each partition should define its own filter, or lack of filter?
> > That sounds reasonable.
> >
>
> If the partition is not published by the root, it shouldn't use the
> filter defined on the root. I wonder what should happen to the filter
> defined on the partition itself. I'd say
>
> pubviaroot=false -> use filter defined on partition (if any)
>
> pubviaroot=true -> use filter defined on root (if any)
>
>
> I wonder what the row filter patch is doing - we should probably follow
> the same logic, if only to keep the filtering stuff consistent.
>

The row filter patch is doing the same and additionally, it gives an
error if the user provides a filter for a partitioned table with
pubviaroot as false.

--
With Regards,
Amit Kapila.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2022-02-16 10:05:34 Re: Column Filtering in Logical Replication
Previous Message Heikki Linnakangas 2022-02-16 09:07:15 Re: Table AM and DROP TABLE [ Was: Table AM and DDLs]