| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Markus Wanner <markus(at)bluegap(dot)ch> |
| Cc: | Ajin Cherian <itsajin(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] logical decoding of two-phase transactions |
| Date: | 2021-02-23 02:13:53 |
| Message-ID: | CAA4eK1Lk1jMFMn=_4DFUC=EqAHF_CvdcUY3a1UN0=F0=ZOiB4A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Feb 22, 2021 at 11:04 PM Markus Wanner <markus(at)bluegap(dot)ch> wrote:
>
> On 04.01.21 09:18, Amit Kapila wrote:
> > Thanks, I have pushed the 0001* patch after making the above and a few
> > other cosmetic modifications.
>
> That commit added the following snippet to the top of
> ReorderBufferFinishPrepared:
>
> txn = ReorderBufferTXNByXid(rb, xid, true, NULL, commit_lsn, false);
>
> /* unknown transaction, nothing to do */
> if (txn == NULL)
> return;
>
> Passing true for the create argument seems like an oversight. I think
> this should pass false and not ever (have to) create a ReorderBufferTXN
> entry.
>
Right, I'll push a fix for this. Thanks for the report!
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2021-02-23 03:26:39 | Re: locking [user] catalog tables vs 2pc vs logical rep |
| Previous Message | Andres Freund | 2021-02-23 02:01:05 | Re: Hybrid Hash/Nested Loop joins and caching results from subplans |