| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Rajeev rastogi <rajeev(dot)rastogi(at)huawei(dot)com> |
| Cc: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)2ndquadrant(dot)com>, Kouhei Kaigai <kaigai(at)ak(dot)jp(dot)nec(dot)com>, Amit Langote <amitlangote09(at)gmail(dot)com>, Fabrízio Mello <fabriziomello(at)gmail(dot)com>, Thom Brown <thom(at)linux(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Parallel Seq Scan |
| Date: | 2015-03-25 10:30:17 |
| Message-ID: | CAA4eK1LipOpmPTWu5LbFroJScKbV2QQpa_BRZ7vDfOKePdtkOA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Mar 25, 2015 at 3:47 PM, Rajeev rastogi <rajeev(dot)rastogi(at)huawei(dot)com>
wrote:
>
> On 20 March 2015 17:37, Amit Kapila Wrote:
>
> > So the patches have to be applied in below sequence:
> > HEAD Commit-id : 8d1f2390
> > parallel-mode-v8.1.patch [2]
> > assess-parallel-safety-v4.patch [1]
> > parallel-heap-scan.patch [3]
> > parallel_seqscan_v11.patch (Attached with this mail)
>
> While I was going through this patch, I observed one invalid ASSERT in
the function “ExecInitFunnel” i.e.
>
> Assert(outerPlan(node) == NULL);
>
> Outer node of Funnel node is always non-NULL and currently it will be
PartialSeqScan Node.
>
Which version of patch you are looking at?
I am seeing below code in ExecInitFunnel() in Version-11 to which
you have replied.
+ /* Funnel node doesn't have innerPlan node. */
+ Assert(innerPlan(node) == NULL);
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2015-03-25 10:35:04 | Re: assessing parallel-safety |
| Previous Message | Shigeru HANADA | 2015-03-25 10:29:45 | Re: Custom/Foreign-Join-APIs (Re: [v9.5] Custom Plan API) |