| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Resetting spilled txn statistics in pg_stat_replication |
| Date: | 2020-10-21 03:56:56 |
| Message-ID: | CAA4eK1LdPQucvp9St2D6NhO9aQ2KKr3U0yAbKDox2UC86Q+_zg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Oct 13, 2020 at 10:33 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Tue, Oct 13, 2020 at 10:21 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> >
> >
> > I know I can go read the source code, but most users will not want to.
> > Is the documentation in monitoring.sgml really sufficient? If we can't
> > explain this with more precision, is it really a number we want to expose
> > at all?
> >
>
> This counter is important to give users an idea about the amount of
> I/O we incur during decoding and to tune logical_decoding_work_mem
> GUC. So, I would prefer to improve the documentation for this
> variable.
>
I have modified the description of spill_count and spill_txns to make
things clear. Any suggestions?
--
With Regards,
Amit Kapila.
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Update-description-of-spilled-counters-in-pg_stat.patch | application/octet-stream | 1.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2020-10-21 04:17:23 | Re: Track statistics for streaming of in-progress transactions |
| Previous Message | Masahiko Sawada | 2020-10-21 02:44:47 | Re: Track statistics for streaming of in-progress transactions |