From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
---|---|
To: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
Cc: | vignesh C <vignesh21(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Ryan Lambert <ryan(at)rustprooflabs(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Anthony Nowocien <anowocien(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Filip Rembiałkowski <filip(dot)rembialkowski(at)gmail(dot)com> |
Subject: | Re: dropdb --force |
Date: | 2019-11-18 06:36:50 |
Message-ID: | CAA4eK1LcWZVnj795vRpTH1A2ied9kYhTukUi8mYJN_m3wf_CxA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, Nov 18, 2019 at 10:59 AM Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> wrote:
> po 18. 11. 2019 v 6:24 odesílatel Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> napsal:
>>
>> On Mon, Nov 18, 2019 at 10:33 AM Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> wrote:
>> >
>> > po 18. 11. 2019 v 4:43 odesílatel vignesh C <vignesh21(at)gmail(dot)com> napsal:
>> >>
>> >>
>> >> I had seen that isolation test(src/test/isolation) has a framework to
>> >> support this. You can have a look to see if it can be handled using
>> >> that.
>> >
>> >
>> > I'll look there
>> >
>>
>> If we want to have a test for this, then you might want to look at
>> test src/test/recovery/t/013_crash_restart. In that test, we keep a
>> connection open and then validate whether it is terminated. Having
>> said that, I think it might be better to add this as a separate test
>> patch apart from main patch because it is a bit of a timing-dependent
>> test and might fail on some slow machines. We can always revert this
>> if it turns out to be an unstable test.
>
>
> +1
>
So, are you planning to give it a try? I think even if we want to
commit this separately, it is better to have a test for this before we
commit.
--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | Masahiko Sawada | 2019-11-18 06:38:36 | Re: [HACKERS] Block level parallel vacuum |
Previous Message | Amit Kapila | 2019-11-18 06:34:36 | Re: [HACKERS] Block level parallel vacuum |