Re: Conflict detection for multiple_unique_conflicts in logical replication

On Tue, Mar 25, 2025 at 8:51 AM vignesh C <vignesh21(at)gmail(dot)com> wrote:
>
> On Fri, 21 Mar 2025 at 16:44, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com> wrote:
> >
> > On Fri, Mar 21, 2025 at 3:38 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> > >
> > > On Fri, Mar 21, 2025 at 1:48 PM Zhijie Hou (Fujitsu)
> > > <houzj(dot)fnst(at)fujitsu(dot)com> wrote:
> > > >
> > > > On Fri, Mar 21, 2025 at 12:50 PM Nisha Moond wrote:
> > > >
> > > > > Thanks, Hou-san, for the review and fix patches. I’ve incorporated
> > > > > your suggestions.
> > > > > Attached are the v7 patches, including patch 002, which implements
> > > > > stats collection for 'multiple_unique_conflicts' in pg_stat_subscription_stats.
> > > >
> > > > Thanks for updating the patches.
> > > >
> > > > Here are some more comments:
> > > >
> > > > 1.
> > > >
> > > > The comments atop of ReportApplyConflict() should be updated to reflect the
> > > > updates made to the input parameters.
> > > >
> > >
> > > Right, I also noticed this and updated it in the attached. Apart from
> > > this, I have made a number of cosmetic changes in the attached. Please
> > > review and include it in the next version unless you see any problem
> > > with it.
> > >
> >
> > Thanks for the review.
> >
> > I’ve incorporated the changes and also addressed Hou-san’s comments
> > from [1] with suggested changes.
> >
> > Attached are the v8 patches.
>
> Shouldn't these statements be the other way:
> pass('multiple_unique_conflicts detected during update');
> should have been:
> pass('multiple_unique_conflicts detected during insert');
>
> and
> pass('multiple_unique_conflicts detected during insert');
> should have been:
> pass('multiple_unique_conflicts detected during update');
>
> if you are ok with above change, the attached patch has the change for the same.
>

LGTM and thanks for the report. I'll push this change.

--
With Regards,
Amit Kapila.