From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
---|---|
To: | Bruce Momjian <bruce(at)momjian(dot)us> |
Cc: | Vladimir Borodin <root(at)simply(dot)name>, Dmitriy Sarafannikov <dsarafannikov(at)yandex(dot)ru>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Broken hint bits (freeze) |
Date: | 2017-06-15 09:30:18 |
Message-ID: | CAA4eK1LZ4_My_1Usus5jKYqJ8sz=02cmFKxHT8160Sph7mKkZA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Jun 14, 2017 at 8:44 PM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> On Wed, Jun 14, 2017 at 07:45:17PM +0530, Amit Kapila wrote:
>> > Now, it seems we later added a doc section early on that talks about
>> > "Verify standby servers" so I have moved the wal_level section into that
>> > block, which should be safe. There is now no need to start/stop the new
>> > server since pg_upgrade will do that safely already.
>> >
>>
>> ! <para>
>> ! Also, if upgrading standby servers, change <varname>wal_level</>
>> ! to <literal>replica</> in the <filename>postgresql.conf</> file on
>> ! the new cluster.
>>
>> I think it is better to indicate that this is required for the master
>> cluster (probably it is clear for users) /"on the new cluster."/"on
>> the new master cluster.". Do we need something different for v10 where
>> default wal_level is 'replica'
>
> You know, I thought about that and was afraid saying "new master
> cluster" would be confusing because it isn't a master _yet_, but if you
> feel it will help, and I considered it, let's add it. The problem is
> that in the old instructions, at the point we were mentioning this, it
> was the new master, which is why I evaluated removing it in the first
> place. (Yeah, I am amazed I considered all these cases.)
>
> Updated patch attached. Thanks.
>
Looks good to me.
--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Langote | 2017-06-15 10:36:43 | Re: A bug in mapping attributes in ATExecAttachPartition() |
Previous Message | Ashutosh Bapat | 2017-06-15 09:05:09 | Re: A bug in mapping attributes in ATExecAttachPartition() |