From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Jesper Pedersen <jesper(dot)pedersen(at)redhat(dot)com>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Write Ahead Logging for Hash Indexes |
Date: | 2017-02-13 15:22:09 |
Message-ID: | CAA4eK1LTyDHyCmj3pf5KxWgPb1DgNae9ivsB5jX0X_Kt7iLTUA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Feb 10, 2017 at 12:15 PM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> On Thu, Feb 9, 2017 at 10:28 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>
>> The things that look like preliminary refactoring to
>> me are:
>>
>> - Adding _hash_pgaddmultitup and using it in various places.
>> - Adding and freeing overflow pages has been extensively reworked.
>>
>
> Freeing the overflow page is too tightly coupled with changes related
> to _hash_pgaddmultitup, so it might be better to keep it along with
> it. However, I think we can prepare a separate patch for changes
> related to adding the overflow page.
>
>> - Similarly, there is some refactoring of how bitmap pages get initialized.
>> - Index initialization has been rejiggered significantly.
>> - Bucket splits have been rejiggered.
>>
>
As discussed, attached are refactoring patches and a patch to enable
WAL for the hash index on top of them.
--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
Attachment | Content-Type | Size |
---|---|---|
0001-Expose-a-new-API-_hash_pgaddmultitup-to-add-multiple.patch | application/octet-stream | 16.3 KB |
0002-Expose-hashinitbitmapbuffer-to-initialize-bitmap-pag.patch | application/octet-stream | 2.5 KB |
0003-Restructure-_hash_addovflpage-so-that-the-operation-.patch | application/octet-stream | 11.1 KB |
0004-restructure-split-bucket-code-so-that-the-operation-.patch | application/octet-stream | 10.6 KB |
0005-Restructure-hash-index-creation-and-metapage-initial.patch | application/octet-stream | 14.5 KB |
0006-Enable-WAL-for-Hash-Indexes.patch | application/octet-stream | 89.8 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2017-02-13 15:42:25 | Re: [ patch ] pg_dump: new --custom-fetch-table and --custom-fetch-value parameters |
Previous Message | Kyle Gearhart | 2017-02-13 14:46:26 | Re: libpq Alternate Row Processor |