Re: Fix assert failure when decoding XLOG_PARAMETER_CHANGE on primary

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Cc: Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Fix assert failure when decoding XLOG_PARAMETER_CHANGE on primary
Date: 2025-02-06 06:16:50
Message-ID: CAA4eK1LQbm7JQA8feNoztDFccduFTVFs+51hm_U56tvunCAmOg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Feb 6, 2025 at 12:30 AM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>
> I've updated the patch accordingly.
>

Today, again thinking about the proposed fix, I was wondering about
the following case. Say, on hot_standby, the user created a logical
slot, then shut down hot_standby, turn off the hot_standby flag, and
restart standby. This is allowed today but not after the patch. It is
possible that the user can promote a non-hot_standby server after its
restart in the previous step and can reuse the logical slot. So, is it
okay to change this behavior? If not, then we may need to go back to
the first fix proposed by you in this thread.

--
With Regards,
Amit Kapila.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bertrand Drouvot 2025-02-06 06:55:54 Re: Failed assertion with jit enabled
Previous Message Michael Paquier 2025-02-06 06:01:47 Re: Test to dump and restore objects left behind by regression