From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
---|---|
To: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: rename SnapBuild* macros in slot.c |
Date: | 2021-11-22 11:42:00 |
Message-ID: | CAA4eK1LPE-3vvN-kHj_ruBOVuVDirtjmKPRUUfQV=H49ua65Ww@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sat, Nov 20, 2021 at 7:43 PM Bharath Rupireddy
<bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
>
> It seems like the same macro names for
> SnapBuildOnDiskNotChecksummedSize and SnapBuildOnDiskChecksummedSize
> are being used in slot.c and snapbuild.c. I think, in slot.c, we can
> rename them to ReplicationSlotOnDiskNotChecksummedSize and
> ReplicationSlotOnDiskChecksummedSize
> similar to the other macros ReplicationSlotOnDiskConstantSize and
> ReplicationSlotOnDiskV2Size.
>
+1 for this change. This seems to be introduced by commit ec5896aed3
[1] and I think it is just a typo to name these macros starting with
SnapBuildOnDisk* unless I am missing something.
[1]
commit ec5896aed3c01da24c1f335f138817e9890d68b6
Author: Andres Freund <andres(at)anarazel(dot)de>
Date: Wed Nov 12 18:52:49 2014 +0100
Fix several weaknesses in slot and logical replication on-disk
serialization.
--
With Regards,
Amit Kapila.
From | Date | Subject | |
---|---|---|---|
Next Message | Daniel Gustafsson | 2021-11-22 11:58:36 | Re: add missing errdetail for xlogreader allocation failure error |
Previous Message | Daniel Gustafsson | 2021-11-22 11:17:30 | Re: Windows build warnings |