From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
---|---|
To: | Mithun Cy <mithun(dot)cy(at)enterprisedb(dot)com> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Explain [Analyze] produces parallel scan for select Into table statements. |
Date: | 2016-03-12 09:02:55 |
Message-ID: | CAA4eK1LOut7G+TgEpfsP2UZpteMP35DM6=yi8u_3xJnOtVBZkg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sat, Mar 12, 2016 at 2:02 PM, Mithun Cy <mithun(dot)cy(at)enterprisedb(dot)com>
wrote:
>
>
>
> On Sat, Mar 12, 2016 at 12:28 PM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
wrote
> >I don't see how this test will fail with force_parallel_mode=regress and
max_parallel_degree > 0 even without the patch proposed to fix the issue in
>hand. In short, I don't think this test would have caught the issue, so I
don't see much advantage in adding such a test. Even if we want to add
such a >test case, I think as proposed this will substantially increase the
timing for "Select Into" test which might not be an acceptable test case
addition >especially for testing one corner case.
>
>
> Without above patch the make installcheck fails for select_into.sql with
below diff
>
> when
> force_parallel_mode = on
> max_parallel_degree = 3
>
With force_parallel_mode=on, I could see many other failures as well. I
think it is better to have test, which tests this functionality with
force_parallel_mode=regress
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | Alexander Korotkov | 2016-03-12 09:08:51 | Re: Background Processes and reporting |
Previous Message | Michael Paquier | 2016-03-12 08:50:10 | Re: [PATCH] Use MemoryContextAlloc() in the MemoryContextAllocZero() and MemoryContextAllocZeroAligned() |