| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, "Anton A(dot) Melnikov" <aamelnikov(at)inbox(dot)ru>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Maxim Orlov <orlovmg(at)gmail(dot)com> |
| Subject: | Re: [BUG] Logical replica crash if there was an error in a function. |
| Date: | 2022-11-03 04:11:46 |
| Message-ID: | CAA4eK1LO-xrD_S1xEHYt1_9uszivicUvNRfWO8D+Qm8tuFTDBA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Nov 2, 2022 at 11:32 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> So I'm now good with the idea of just not failing. I don't like
> the patch as presented though. First, the cfbot is quite rightly
> complaining about the "uninitialized variable" warning it draws.
> Second, I don't see a good reason to tie the change to logical
> replication in any way. Let's just change the Assert to an if(),
> as attached.
>
LGTM. I don't know if it is a good idea to omit the test case for this
scenario. If required, we can reuse the test case from Sawada-San's
patch in the email [1].
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | John Naylor | 2022-11-03 04:59:33 | Re: [PoC] Improve dead tuple storage for lazy vacuum |
| Previous Message | Julien Rouhaud | 2022-11-03 04:09:36 | Re: proposal: possibility to read dumped table's name from file |