From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
---|---|
To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Francisco Olarte <folarte(at)peoplecall(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | vacuumdb -f and -j options (was Question / requests.) |
Date: | 2016-10-08 12:12:39 |
Message-ID: | CAA4eK1LL82mKeNJFagwPK0SfsxahOSno-Ncp7QpevoYj0NHUhQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Oct 7, 2016 at 10:16 PM, Alvaro Herrera
<alvherre(at)2ndquadrant(dot)com> wrote:
> Robert Haas wrote:
>> On Wed, Oct 5, 2016 at 10:58 AM, Francisco Olarte
>> I don't know, but it seems like the documentation for vacuumdb
>> currently says, more or less, "Hey, if you use -j with -f, it may not
>> work!", which seems unacceptable to me. It should be the job of the
>> person writing the feature to make it work in all cases, not the job
>> of the person using the feature to work around the problem when it
>> doesn't.
>
> The most interesting use case of vacuumdb is lazy vacuuming, I think, so
> committing that patch as it was submitted previously was a good step
> forward even if it didn't handle VACUUM FULL 100%.
>
> I agree that it's better to have both modes Just Work in parallel, which
> is the point of this subsequent patch. So let's move forward. I
> support Francisco's effort to make -f work with -j. I don't have a
> strong opinion on which of the various proposals presented so far is the
> best way to implement it, but let's figure that out and get it done.
>
After reading Francisco's proposal [1], I don't think it is directly
trying to make -f and -j work together. He is proposing to make it
work by providing some new options. As you are wondering upthread, I
think it seems reasonable to disallow -f with parallel vacuuming if no
tables are specified.
--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2016-10-08 12:22:07 | Re: vacuumdb -f and -j options (was Question / requests.) |
Previous Message | Michael Paquier | 2016-10-08 12:08:50 | Re: pg_dump getBlobs query broken for 7.3 servers |