Re: locking [user] catalog tables vs 2pc vs logical rep

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: "osumi(dot)takamichi(at)fujitsu(dot)com" <osumi(dot)takamichi(at)fujitsu(dot)com>
Cc: vignesh C <vignesh21(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Markus Wanner <markus(dot)wanner(at)enterprisedb(dot)com>
Subject: Re: locking [user] catalog tables vs 2pc vs logical rep
Date: 2021-06-09 08:48:35
Message-ID: CAA4eK1LL+dF9Yn9NbvO3HP5dnCWKTDczc9UrSqwCohKaFJa+jw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jun 9, 2021 at 12:03 PM osumi(dot)takamichi(at)fujitsu(dot)com
<osumi(dot)takamichi(at)fujitsu(dot)com> wrote:
>
> On Wednesday, June 9, 2021 12:06 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> > On Tue, Jun 8, 2021 at 6:24 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
>
> > > 3) Should [user] catalog tables be catalog tables or user catalog
> > > tables [user] catalog tables
> > >
> >
> > The third point is not clear. Can you please elaborate by quoting the exact
> > change from the patch?
> IIUC, he means to replace all descriptions "[user] catalog tables"
> with "catalog tables or user catalog tables" in the patch,
> because seemingly we don't use square brackets to describe optional clause in
> normal descriptions(like outside of synopsis and I don't find any example for this).
> But, even if so, I would like to keep the current square brackets description,
> which makes sentence short and simple.
>

+1.

--
With Regards,
Amit Kapila.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2021-06-09 09:10:24 Re: logical replication of truncate command with trigger causes Assert
Previous Message Kyotaro Horiguchi 2021-06-09 08:17:51 Re: Logical replication keepalive flood