From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
---|---|
To: | MauMau <maumau307(at)gmail(dot)com> |
Cc: | Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [bug fix] pg_ctl always uses the same event source |
Date: | 2013-12-23 04:51:37 |
Message-ID: | CAA4eK1LDo7fRXHVv=B8_8xvQ4xBusiP4QAVHzTQJEf6FB-KBkA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Dec 20, 2013 at 5:26 PM, MauMau <maumau307(at)gmail(dot)com> wrote:
> From: "Amit Kapila" <amit(dot)kapila16(at)gmail(dot)com>
>>
>> Few other points:
>>
>> -------------------------
>> 1.
>> #ifdef WIN32
>> /* Get event source from postgresql.conf for eventlog output */
>> get_config_value("event_source", event_source, sizeof(event_source));
>> #endif
>>
>> event logging is done for both win32 and cygwin env.
>> under hash define (Win32 || cygwin),
>> so event source name should also be retrieved for both
>> environments. Refer below in code:
>>
>> #if defined(WIN32) || defined(__CYGWIN__)
>> static void
>> write_eventlog(int level, const char *line)
>>
>> 2.
>> Docs needs to be updated for default value:
>> http://www.postgresql.org/docs/devel/static/event-log-registration.html
>>
>> http://www.postgresql.org/docs/devel/static/runtime-config-logging.html#GUC-EVENT-SOURCE
>
>
> Okay, done. Thanks. I'll update the commitfest entry this weekend.
Your changes are fine. The main part left from myside is test of this patch.
I will do that in next CF or If I get time before that, I will try to
complete it.
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | David Fetter | 2013-12-23 05:20:49 | Re: GiST support for inet datatypes |
Previous Message | Amit Kapila | 2013-12-23 04:30:56 | Re: Issue with PGC_BACKEND parameters |