| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com> |
| Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, Amit Langote <amitlangote09(at)gmail(dot)com>, Greg Nancarrow <gregn4422(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, vignesh C <vignesh21(at)gmail(dot)com>, David Rowley <dgrowleyml(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "tsunakawa(dot)takay(at)fujitsu(dot)com" <tsunakawa(dot)takay(at)fujitsu(dot)com>, "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com> |
| Subject: | Re: Parallel INSERT (INTO ... SELECT ...) |
| Date: | 2021-03-18 11:11:41 |
| Message-ID: | CAA4eK1L7qXqZCm-MS4shY=iXTCjopiKp7qe6eTs0TJvr+Teh0A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Mar 18, 2021 at 9:04 AM houzj(dot)fnst(at)fujitsu(dot)com
<houzj(dot)fnst(at)fujitsu(dot)com> wrote:
>
> > > If a table parameter value is set and the
> > > equivalent <literal>toast.</literal> parameter is not, the TOAST table
> > > will use the table's parameter value.
> > > - Specifying these parameters for partitioned tables is not supported,
> > > - but you may specify them for individual leaf partitions.
> > > + These parameters, with the exception of
> > > + <literal>parallel_insert_enabled</literal>,
> > > + are not supported on partitioned tables, but may be specified for
> > > + individual leaf partitions.
> > > </para>
> > >
> >
> > Your patch looks good to me. While checking this, I notice a typo in the
> > previous patch:
> > - planner parameter <varname>parallel_workers</varname>.
> > + planner parameter <varname>parallel_workers</varname> and
> > + <varname>parallel_insert_enabled</varname>.
> >
> > Here, it should be /planner parameter/planner parameters.
>
> Thanks amit and justin for pointing this out !
> The changes looks good to me.
>
Pushed!
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2021-03-18 11:27:02 | Re: SSL SNI |
| Previous Message | Dilip Kumar | 2021-03-18 11:10:41 | Re: [HACKERS] Custom compression methods |